CI: fix documentation #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7092986748
💛 - Coveralls |
|
It seems that the problem comes from bindgen being broken when using clang 14 and newer. I initially failed to reproduce the error locally because I was still running clang 11. hacl-packages/.github/workflows/rust.yml Line 43 in eb9f9c6 Since it works on macOS, I suggest we use this for now. |
franziskuskiefer
requested changes
Dec 4, 2023
franziskuskiefer
approved these changes
Dec 5, 2023
protz
pushed a commit
that referenced
this pull request
Apr 18, 2024
* ci: build static content on pull requests * ci: update `setup-rust-action` when building static content * ci: build documentation on macos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the GitHub action deploying the documentation.
It currently fails on main, but I am unable to reproduce the error locally.
This PR also enables building the documentation (but not deploying it) on pull requests, to avoid bad surprises when merging in the future.