Fix MSVC+CPP issue with including eurydice_glue.h w/ C++17 #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel-lee-msft
commented
May 16, 2024
samuel-lee-msft
commented
- Without this MSVC generates error C7555 when eurydice_glue.h is included in any C++ source (https://godbolt.org/z/EqcvcG3Yj)
+ Without this MSVC generates error C7555 when eurydice_glue.h is included in any C++ source (https://godbolt.org/z/EqcvcG3Yj)
|
We require contributors to sign our Contributor License Agreement https://github.com/cryspen/hacl/blob/main/CLA.md ensuring that the contribution can be licensed under Apache 2.0 and MIT. In order for us to review and merge your code, please mention @cryspen/core in a comment below to get yourself added. |
franziskuskiefer
approved these changes
May 17, 2024
Pull Request Test Coverage Report for Build 9565090194Details
💛 - Coveralls |
|
I am happy to agree to the CLA and be added to the list of contributors for this PR |
|
Let me know if there is anything blocking completion of this PR |
franziskuskiefer
approved these changes
Jun 18, 2024
|
Sorry for the delay, merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.