Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nightly hax extraction job and git pre-commit hook. #121

Merged
merged 8 commits into from
Oct 25, 2023
Merged

Conversation

xvzcf
Copy link
Contributor

@xvzcf xvzcf commented Oct 24, 2023

No description provided.

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. lgtm with two nits.

  • While renaming the python script. Shall we rename it to something more generic to not only extract but also do proofs etc?
  • Please add instructions on how to use the git hooks to the readme or a separate CONTRIBUTING.md

@xvzcf
Copy link
Contributor Author

xvzcf commented Oct 25, 2023

* While renaming the python script. Shall we rename it to something more generic to not only extract but also do proofs etc?

What do you envision? Should we name it to something like fstar-utils?

* Please add instructions on how to use the git hooks to the readme or a separate `CONTRIBUTING.md`

Done.

@franziskuskiefer
Copy link
Member

What do you envision? Should we name it to something like fstar-utils?

Not sure.. I'm bad at naming things 😬
But I see this as the helper script to extract and run proofs, and do whatever else needed for the verification workflows. So this will probably include lean as well at some point. So I'd go more towards verify (which might be misleading), or just hax (as it's all hax based). I think I like hax ...

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@xvzcf xvzcf merged commit 3e1a096 into dev Oct 25, 2023
9 checks passed
@xvzcf xvzcf deleted the git-stuff branch October 25, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants