Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning on #not_nil! usage #284

Closed
Sija opened this issue Oct 29, 2022 · 0 comments · Fixed by #288
Closed

Warning on #not_nil! usage #284

Sija opened this issue Oct 29, 2022 · 0 comments · Fixed by #288
Assignees
@Sija
Labels
good first issue rule
Milestone
1.3.0

Comments

@Sija
Copy link
Member

Sija commented Oct 29, 2022

Object#not_nil! shouldn't rly be used and is considered as a code smell.
Assigning to a local variable is preferable.
Exceptions as always, can be excluded if desired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sija Sija

Labels
good first issue rule
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Add Lint/NotNil rule crystal-ameba/ameba
1 participant
@Sija