Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make InlineComments::COMMENT_DIRECTIVE_REGEX more strict #146

Merged
merged 1 commit into from Apr 11, 2020
Merged

Make InlineComments::COMMENT_DIRECTIVE_REGEX more strict #146

merged 1 commit into from Apr 11, 2020

Conversation

Sija
Copy link
Member

@Sija Sija commented Apr 10, 2020

Closes #145

veelenga
veelenga reviewed Apr 11, 2020
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks.

Could you please respect the assignee next time. It was planned to be a first issue to solve by @pavloo

src/ameba/rule/lint/bad_directive.cr Outdated Show resolved Hide resolved
@pavloo pavloo assigned pavloo and unassigned pavloo Apr 11, 2020
@veelenga veelenga merged commit 1a25583 into crystal-ameba:master Apr 11, 2020
@veelenga
Copy link
Member

Thank you!

@Sija Sija added the refactor label Oct 30, 2022
@Sija Sija changed the title Make InlineComments::COMMENT_DIRECTIVE_REGEX more strict Make InlineComments::COMMENT_DIRECTIVE_REGEX more strict Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga left review comments

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More strict comment directive
3 participants
@Sija @veelenga @pavloo