Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use String#hash instead of Digest::SHA1.hexdigest #286

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Use String#hash instead of Digest::SHA1.hexdigest #286

merged 1 commit into from
Oct 30, 2022

Conversation

Sija
Copy link
Member

@Sija Sija commented Oct 29, 2022

Fixes #285

@Sija Sija added the bug label Oct 29, 2022
@Sija Sija requested a review from veelenga October 29, 2022 19:44
@Sija Sija self-assigned this Oct 29, 2022
veelenga
veelenga approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Sija Sija merged commit 09aea3d into master Oct 30, 2022
@Sija Sija deleted the Sija/fix-issue-285 branch October 30, 2022 09:46
@Sija Sija added refactor and removed bug labels Oct 30, 2022
@Sija Sija added this to the 1.3.0 milestone Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
refactor
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Can't get ameba to compile on macOS 12.6
2 participants
@Sija @veelenga