Refactor StaticComparison + rename to LiteralsComparison
#293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
force-pushed
the
Sija/refactor-static-comparison-rule
branch
from
6e85b21
to
75af2ec
Compare
Sija
commented
Nov 2, 2022
Comment on lines
+61
to
+62
| is_dynamic = obj.class.in?(DYNAMIC_LITERAL_TYPES) || | ||
| arg.class.in?(DYNAMIC_LITERAL_TYPES) |
There was a problem hiding this comment.
This could have a recursive check in re: to the container types, to see whether they consist of all primitives, and thus can be deemed static. I've left it as a potential further improvement, plus it's a pretty minor detail.
Sija
changed the title
Lint/StaticComparison to LiteralsComparisonStaticComparison + rename to LiteralsComparison
Sija
force-pushed
the
Sija/refactor-static-comparison-rule
branch
from
75af2ec
to
6bf8db8
Compare
So, the comparisons like `Regex == 1=42` will also be detected.
veelenga
approved these changes
Nov 2, 2022
|
I am going to prepare a new release if you are ok with that. |
|
@veelenga Sure, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #292 (comment)