Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further refinements #317

Merged
merged 14 commits into from
Dec 11, 2022
Merged

Further refinements #317

merged 14 commits into from
Dec 11, 2022

Conversation

Sija
Copy link
Member

@Sija Sija commented Dec 8, 2022

No description provided.

@Sija Sija added the refactor label Dec 8, 2022
@Sija Sija added this to the 1.4.0 milestone Dec 8, 2022
@Sija Sija requested a review from veelenga December 8, 2022 13:17
@Sija Sija self-assigned this Dec 8, 2022
@Sija Sija force-pushed the Sija/further-refinements branch 2 times, most recently from ca65b37 to c5138d8 Compare December 8, 2022 15:58
@Sija Sija requested a review from veelenga December 9, 2022 23:35
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija merged commit 4533e52 into master Dec 11, 2022
@Sija Sija deleted the Sija/further-refinements branch December 11, 2022 12:25
@Sija Sija linked an issue Dec 18, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint/LiteralsComparison not always accurate
2 participants