Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Lint/MissingBlockArgument rule #321

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Add Lint/MissingBlockArgument rule #321

merged 2 commits into from
Dec 20, 2022

Conversation

Sija
Copy link
Member

@Sija Sija commented Dec 17, 2022

Reports yielding method definitions without block argument, as below:

def foo
  yield 42
end

@Sija Sija added the rule label Dec 17, 2022
@Sija Sija added this to the 1.4.0 milestone Dec 17, 2022
@Sija Sija requested a review from veelenga December 17, 2022 17:38
@Sija Sija self-assigned this Dec 17, 2022
@Sija Sija force-pushed the Sija/lint-missing-block-argument-rule branch from 7ff3ac2 to 6b6cc8e Compare December 18, 2022 19:14
@Sija Sija force-pushed the Sija/lint-missing-block-argument-rule branch from 6b6cc8e to f99dd42 Compare December 18, 2022 21:53
@Sija Sija requested a review from veelenga December 18, 2022 21:54
@Sija Sija force-pushed the Sija/lint-missing-block-argument-rule branch from f99dd42 to 47b92fb Compare December 20, 2022 14:31
veelenga
veelenga approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija merged commit b78e2ae into master Dec 20, 2022
@Sija Sija deleted the Sija/lint-missing-block-argument-rule branch December 20, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
rule
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sija @veelenga