Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Lint/NotNilAfterNoBang report calls to #rindex #323

Merged
merged 1 commit into from
May 1, 2023
Merged

Make Lint/NotNilAfterNoBang report calls to #rindex #323

merged 1 commit into from
May 1, 2023

Conversation

Sija
Copy link
Member

@Sija Sija commented Dec 18, 2022 •
edited

Requires Crystal 1.7.0

@Sija Sija self-assigned this Dec 18, 2022
@Sija Sija requested a review from veelenga December 18, 2022 19:22
@Sija Sija added this to the 1.5.0 milestone Dec 18, 2022
@Sija Sija force-pushed the Sija/lint-not-nil-after-no-bang-reports-rindex-calls branch from c55c260 to 4284e2e Compare December 23, 2022 00:35
@Sija Sija force-pushed the Sija/lint-not-nil-after-no-bang-reports-rindex-calls branch from 4284e2e to ce4dd72 Compare January 10, 2023 12:37
veelenga
veelenga approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we drop support of Crystal 1.6 once this is merged?

@veelenga veelenga marked this pull request as ready for review January 10, 2023 14:49
@Sija
Copy link
Member Author

Sija commented Jan 10, 2023

@veelenga yup, I'd release 1.4.0 as the last release supporting Crystal <= 1.6 and use 1.5.0 for Crystal 1.7+ support.

@veelenga
Copy link
Member

veelenga commented Jan 10, 2023 •
edited

Sounds good to me. When do you think we are ready to release?

@veelenga
Copy link
Member

veelenga commented Jan 15, 2023 •
edited

@Sija are we good merging this and making a release?

@Sija
Copy link
Member Author

Sija commented Jan 15, 2023

@veelenga This should go into 1.5.0.

@Sija Sija mentioned this pull request Feb 17, 2023
Closed
@Sija Sija merged commit 14f6ba0 into master May 1, 2023
@Sija Sija deleted the Sija/lint-not-nil-after-no-bang-reports-rindex-calls branch May 1, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
enhancement rule
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sija @veelenga