Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocorrect for Style/UnlessElse #325

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

FnControlOption
Copy link
Contributor

Added helper methods for string indices because I find them easier to reason about with

spec/ameba/source_spec.cr Outdated Show resolved Hide resolved
src/ameba/rule/style/unless_else.cr Outdated Show resolved Hide resolved
@Sija Sija added this to the 1.4.0 milestone Dec 19, 2022
@Sija
Copy link
Member

Sija commented Dec 22, 2022

@FnControlOption Hi, I'd like to move forward with this. Is it OK with you if I'd commit directly to your branch?

@FnControlOption
Copy link
Contributor Author

Sure, go ahead (Haven’t had access to a computer the past few days)

@Sija
Copy link
Member

Sija commented Dec 22, 2022

@FnControlOption Will do, thanks! Could you please allow changes to this PR?

image

@FnControlOption
Copy link
Contributor Author

Done

@Sija Sija merged commit 2d9e328 into crystal-ameba:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants