Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove buggy auto-correction from Performance/AnyInsteadOfEmpty rule #341

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

Sija
Copy link
Member

@Sija Sija commented Jan 4, 2023

It was failing in several hard-to-fix edge-cases, so for now I'll remove it in order to avoid producing invalid code.

@Sija Sija added this to the 1.4.0 milestone Jan 4, 2023
@Sija Sija requested a review from veelenga January 4, 2023 01:42
@Sija Sija self-assigned this Jan 4, 2023
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija merged commit a091af1 into master Jan 4, 2023
@Sija Sija deleted the Sija/remove-autocorrections-from-any-instead-of-empty branch January 4, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants