Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Naming/AsciiIdentifiers rule #414

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Add Naming/AsciiIdentifiers rule #414

merged 1 commit into from
Nov 10, 2023

Conversation

Sija
Copy link
Member

@Sija Sija commented Nov 9, 2023

No description provided.

@Sija Sija added the rule label Nov 9, 2023
@Sija Sija added this to the 1.6.0 milestone Nov 9, 2023
@Sija Sija requested a review from veelenga November 9, 2023 05:47
@Sija Sija self-assigned this Nov 9, 2023
@Sija Sija enabled auto-merge November 9, 2023 05:51
@Sija Sija disabled auto-merge November 9, 2023 09:05
veelenga
veelenga approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija merged commit 0abb73f into master Nov 10, 2023
4 checks passed
@Sija Sija deleted the add-ascii-identifiers-rule branch November 10, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota left review comments

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
rule
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sija @straight-shoota @veelenga