Enhance Makefile
#445
Merged
Enhance Makefile
#445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `install` recipe does not rebuild binary * Add `help` target and documentation * Add several config variables * Add sources as dependencies for (in-)validation Based on template https://gist.github.com/straight-shoota/275685fcb8187062208c0871318c4a23
Sija
reviewed
Jan 14, 2024
Sija
approved these changes
Jan 14, 2024
|
@straight-shoota This PR broke my local setup (macOS 12.7) :(
|
|
Are you sure any of the source files changed since you last ran You could also try |
Yeah, I'm sure. Also,
|
|
Hm, looks like make doesn't recognize the prerequisites ( Maybe try this diff to see if there are any errors with the find command? Would be very strange though... @@ -28,7 +28,7 @@ INSTALL_BIN ?= /usr/bin/install
SHARD_BIN ?= ../../bin
CRFLAGS ?= -Dpreview_mt
-SRC_SOURCES ::= $(shell find src -name '*.cr' 2>/dev/null)
+SRC_SOURCES ::= $(shell find src -name '*.cr')
DOC_SOURCE ::= src/**Looks like your make version is really ancient. You might want to update to a more modern version. (Dunno if that could be of any relevance here) |
|
Nope, doesn't work. Also what's interesting when I run this command from my terminal I get: λ Shabdiz → shell find src -name '*.cr'
zsh: command not found: shell |
|
It means run So could you try if |
|
Yeah, that works just fine. |
|
Solution was to install |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured the
Makefilecould use some love after it failed me in some capacities.installrecipe does not rebuild binaryhelptarget and documentationBased on template https://gist.github.com/straight-shoota/275685fcb8187062208c0871318c4a23