Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mediator pattern #15

Merged
merged 3 commits into from Oct 4, 2018
Merged

Add Mediator pattern #15

merged 3 commits into from Oct 4, 2018

Conversation

anicholson
Copy link
Contributor

No description provided.

@anicholson
Copy link
Contributor Author

Part of #9 :)

@veelenga
Copy link
Member

veelenga commented Oct 3, 2018 •
edited

Please rebase, so we will be sure travis passes.

@anicholson
Copy link
Contributor Author

@veelenga done :)

veelenga
veelenga reviewed Oct 3, 2018
View reviewed changes
behavioral/mediator.cr Outdated
elsif (fighter == player2)
player1.as(Fighter).receive(move, fighter)
else
# not a player in this match
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this empty else?

@veelenga
Copy link
Member

veelenga commented Oct 3, 2018

Looks good except one minor comment. Thanks

@anicholson
Copy link
Contributor Author

@veelenga fixed and added outputs to the bottom for extra grokability.

@veelenga veelenga merged commit 78e79f5 into crystal-community:master Oct 4, 2018
@veelenga
Copy link
Member

veelenga commented Oct 4, 2018

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anicholson @veelenga