Refactor API and file stats parsers #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j8r
force-pushed
the
refactor-library
branch
3 times, most recently
from
6436128
to
dd2c6bc
Compare
|
Sorry for the push forces, I am figuring out how much sleep we have to wait to have enough load. |
j8r
force-pushed
the
refactor-library
branch
from
dd2c6bc
to
a01893e
Compare
j8r
force-pushed
the
refactor-library
branch
from
a01893e
to
74a12f1
Compare
veelenga
reviewed
Nov 15, 2019
veelenga
approved these changes
Nov 15, 2019
|
@bararchy have you the time to take a quick look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a quite big refactor of the whole library.
There are fixes to make it work for Crystal 0.31.1, but more importantly the file parsers where optimized to remove intermediate array.
This leads me to redesign the API.
Sorry for the big refactor in a single commit, tell me what you think.
I can split each module refactor in a separate commit, but
PIDdepend onCPU.