Expand tilde in config path #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Crystal 0.32.0, File.expand_path was changed to no longer expand the tilde (~) character by default. This causes icr to create a '~' directory in the current folder. This change restores the old behavior by setting home: true.
|
Thanks. Would you mind to add some catching testcase ? |
Also changed it to use a temp directory instead of polluting pwd.
|
@veelenga Done |
veelenga
approved these changes
Jan 10, 2020
|
Can someone hit merge? =) |
|
Ha. Thanks for the ping 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Crystal 0.32.0, File.expand_path was changed to no longer expand the tilde (~) character by default. This causes icr to create a '~' directory in the current folder.
This change restores the old behavior by setting home: true.
Also includes a commit that adds /lib directory to gitignore.