Feature: paste mode #56
Conversation
src/icr/console.cr
Outdated
| end | ||
|
|
||
| input += input_line | ||
| input += "\n" |
There was a problem hiding this comment.
Strings in Crystal are immutable. So each time you do +=, you create a new string. Use String.build instead.
src/icr/console.cr
Outdated
| input += "\n" | ||
| end | ||
|
|
||
| if input.to_s.strip != "" |
There was a problem hiding this comment.
!input.blank? should be a bit cleaner
|
Tested locally and it works: icr(0.23.1) > |paste
# Entering paste mode (ctrl-D to finish)
puts "hello"
puts "bro"
[1, 2, 3].each { |e| puts e }
^D
# Ctrl-D was pressed, now interpreting...
hello
bro
1
2
3
=> nilBut I'm not sure if we need this because you can just use parenthesis (or icr(0.23.1) > (
icr(0.23.1) > puts "hello"
icr(0.23.1) > puts "bro"
icr(0.23.1) > [1, 2, 3].each { |e| puts e }
icr(0.23.1) > )
hello
bro
1
2
3
=> nil@greyblake WDYT? |
|
Your call guys. I made the requested changes :) |
|
Personally I don't see advantages of @greyblake @crystal-community/maintainers thoughts? |
|
I'll take a look tonight. |
src/icr/console.cr
Outdated
| @@ -28,11 +28,36 @@ module Icr | |||
| __exit__ | |||
| elsif %w(exit quit).includes?(input.to_s.strip) | |||
| __exit__ | |||
| elsif %w(|paste).includes?(input.to_s.strip) | |||
There was a problem hiding this comment.
I guess it would be easier to read if it would be
input.to_s.strip == "|paste"
...
Also, I would prefer to use simply paste without |. Just like exit and quite commands above.
There was a problem hiding this comment.
@greyblake good catch 👍
Using just paste means the user can't use this word as a variable or method name... But really rare case.
There was a problem hiding this comment.
I made the changes. paste doesn't seem like a good variable name anyway. ;)
src/icr/console.cr
Outdated
| input_line = Readline.readline() | ||
|
|
||
| if input_line.nil? | ||
| puts "\n\n# Ctrl-D was pressed, now interpreting...\n" |
There was a problem hiding this comment.
I think interpreting is not the right word here because crystal is compiled language 😄
Maybe better to say: "Ctrl-D was pressed, exiting paste mode... "?
No description provided.