Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary replacement for removed crystal tool format --format json #65

Conversation

asterite
Copy link
Contributor

@asterite asterite commented Feb 7, 2019

Fixes #63
Fixes #64

The --format json was removed (I have no idea why). This is a temporary replacement:

  • we obviously don't pass the --format json option anymore
  • we try to parse the text output to get the line number and error

@asterite
Copy link
Contributor Author

asterite commented Feb 7, 2019

This is better than #64 because it keeps showing errors when they happen.

@vladfaust
Copy link
Contributor

vladfaust commented Feb 7, 2019

Works for me, thanks, @asterite. As of it's being temporary, should we merge this or even release the new version?

It contains commented code which is ideally should not go into a release version, but we're having a 0.x version here... 🤔

Update: I'm using the plugin directly from the git folder, not PackageControl for now, that's why I'm asking

@asterite
Copy link
Contributor Author

asterite commented Feb 7, 2019

This should be merged and a new release done. This will always work and it's almost as good as the version that used --format json.

@vladfaust vladfaust merged commit 67b2c97 into crystal-lang-tools:master Feb 7, 2019
@asterite
Copy link
Contributor Author

asterite commented Feb 7, 2019

Thank you Vlad!

@faustinoaq
Copy link
Member

Tested and working, Thank you @asterite and @vladfaust 👍

@faustinoaq faustinoaq removed the request for review from a team February 7, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants