add explanation and fix example by adding getters #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next example snippet depends on this. This also adds a short explanation on the macros getter, setter, and property.
|
GTG? |
|
Maybe, I don't know if it's a good idea to introduce macros at that point. |
|
Agree, feels a little early. I think it's in the right section but introduced out of order within that section. My suggestion is to move the getter description to the end of that subsection and only briefly mention "macro method" if at all. |
|
I've got a proposal in #62 that is related. |
|
Closing in favor of @andyfleming 's proposal at #62. Feel free to collaborate/discuss there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next example snippet depends on this. This also adds a short
explanation on the macros getter, setter, and property.
This should fix #14.