Transactions don't return the result of the yielded block

[matthewmcgarvey]

It currently returns a boolean of whether or not the transaction was committed successfully

crystal-db/src/db/begin_transaction.cr

Line 29 in eaddae7

tx.commit unless tx.closed?

This is different than Rails, for instance, that does return that value https://github.com/rails/rails/blob/d5386cfba2ec5c80f09e37d44b87bcae9c6ab6a8/activerecord/lib/active_record/connection_adapters/abstract/transaction.rb#L310-L312

I would rather get the result of the block rather than the vague boolean, though I know this will be a breaking change.

[bcardiff]

I agree. I didn't consider the return value for this method.

[BrucePerens]

This has sat around for a while now. I think I would like to add #transaction! which:

• Returns the value of the block unconditionally.
• Raises a unique exception when the transaction is rolled back.

[bcardiff]

The return value can be added to the existing method. There is no documentation for the return value. The current (nilable) boolean is accidental.