added types for int8, int16, Time for mysql driver #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Time will arrive to DB::Any. I am a bit hesitant regarding Int8/Int16. Int8/Int16 and specially UInt8/16 are mainly for interfacing with C. @crisward I am not following why without this PR you get errors in mysql. Can you share some dump/log? |
|
@crisward Int8/16 stories should be fixed at crystal-mysql@master. check crystal-lang/crystal-mysql#18 . I though this would been covered by this spec but the case without unions in the exec args didn't raise the issue you point in the error. If that is ok, then we could close this issue since mysql can extend the type to be used outside DB::Any. |
|
Thanks, that fixes it. I'll close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I get an error on mysql without these.
Related to this - crystal-lang/crystal-mysql#15