New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/datetime #7
Conversation
Think the failing test may be due to the mysql version, I think the microsecond support maybe recent. It's passing locally. travis uses 5.6.? I think - https://docs.travis-ci.com/user/build-environment-updates/2015-04-09/ |
Hey @crisward , why this PR was closed? |
I've included it in the text field PR. I wanted to test them together, I also fixed the failing test (see open PR) |
Oh, It would be better to do it in separate I think. If you were able to fix the failing test I was going to ask for a squash everything here in a single commit so I can merge it. I will do some comments in the text/blob PR. MySql/DateTime-Crystal/Time is less related to text/blob than MySql/Time-Crystal/Time::Span. If it's too much bother, I can pick it up from here and get your changes for DateTime support. As you prefer. I am glad for your contributions and I don't to push them back. |
@bcardiff When you decide to merge a pull request you can choose to squash the commits, so there's no need to ask this anymore :-) |
I forgot about that :-) even so, we need the fix for the test. So @crisward if you can bring that change here I should be able to squash it. |
ok will do |
Got the read and writing of date/time working.
If I've missed anything, let me know.