Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves favicon files to root of site. #15

Merged
merged 2 commits into from Jan 5, 2017
Merged

Moves favicon files to root of site. #15

merged 2 commits into from Jan 5, 2017

Commits on Jan 4, 2017

  1. Moves favicon files to root of site. 

    This has two benefits:

* The docs will automatically pick up the favicon without any work ([see
discussion](crystal-lang/crystal#3832)).
* Less clutter in the `<head>`
    @philnash
    philnash committed Jan 4, 2017
    Copy the full SHA
    f68d463 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2017

  1. Adds link tag back to <head> for PNG favicon. 

    Chrome and Safari will pick the .ico if there are links to both [according to this blog post](http://www.jonathantneal.com/blog/understand-the-favicon/).

The recommended approach from the blog post if you want to serve PNG favicons to browsers that support them is to just have a `<link>` for the PNG favicon. This will get ignored by browsers that don't support PNGs (IE10 and below) and they will then load the default `/favicon.ico`.

This way we can have PNGs in Chrome and Safari and ICO for fallbacks.
    @philnash
    philnash committed Jan 5, 2017
    Copy the full SHA
    92965c6 View commit details
    Browse the repository at this point in the history