Compiler: sizeof(Bool) must be 1, not 0 (#8273)

crystal-lang · Oct 5, 2019 · 0bb318e · 0bb318e
1 parent 7a1112c
commit 0bb318e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/spec/compiler/codegen/sizeof_spec.cr b/spec/compiler/codegen/sizeof_spec.cr
@@ -95,6 +95,10 @@ describe "Code gen: sizeof" do
     run("sizeof(Nil)").to_i.should eq(0)
   end
 
+  it "gets sizeof Bool (#8272)" do
+    run("sizeof(Bool)").to_i.should eq(1)
+  end
+
   it "can use sizeof in type argument (1)" do
     run(%(
       struct StaticArray

diff --git a/src/compiler/crystal/codegen/codegen.cr b/src/compiler/crystal/codegen/codegen.cr
@@ -85,6 +85,9 @@ module Crystal
         # `Pointer(Void).malloc` must work like `Pointer(UInt8).malloc`,
         # that is, consider Void like the size of a byte.
         1
+      elsif type.is_a?(BoolType)
+        # LLVM reports 0 for bool (i1) but it must be 1 because it does occupy memory
+        1
       else
         llvm_typer.size_of(llvm_typer.llvm_type(type))
       end