Set 'NoReturn' type to untyped typeof in FixMissingTypes visitor

crystal-lang · Oct 16, 2017 · 2c61942 · 2c61942
1 parent aaa44da
commit 2c61942
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/compiler/crystal/semantic/cleanup_transformer.cr b/src/compiler/crystal/semantic/cleanup_transformer.cr
@@ -741,12 +741,6 @@ module Crystal
       node
     end
 
-    def transform(node : TypeOf)
-      node = super
-      node.bind_to node.expressions
-      node
-    end
-
     @false_literal : BoolLiteral?
 
     def false_literal

diff --git a/src/compiler/crystal/semantic/fix_missing_types.cr b/src/compiler/crystal/semantic/fix_missing_types.cr
@@ -79,6 +79,12 @@ class Crystal::FixMissingTypes < Crystal::Visitor
     end
   end
 
+  def visit(node : TypeOf)
+    node.expressions.each &.accept self
+    node.type = @program.no_return.metaclass unless node.type?
+    false
+  end
+
   def visit(node : ASTNode)
     true
   end