Apply suggestions from code review

Co-authored-by: Johannes Müller <straightshoota@gmail.com>
crystal-lang · Oct 6, 2022 · 5d0b521 · 5d0b521
1 parent 5cc8f76
commit 5d0b521
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/compiler/crystal/semantic/normalizer.cr b/src/compiler/crystal/semantic/normalizer.cr
@@ -475,9 +475,7 @@ module Crystal
       when Expressions
         body.expressions = extra_expressions + body.expressions
       else
-        new_expressions = Array(ASTNode).new(extra_expressions.size + 1)
-        new_expressions.concat(extra_expressions)
-        new_expressions.push(node.body)
+        new_expressions << node.body
 
         node.body = Expressions.new(new_expressions).at(node.body)
       end

diff --git a/src/compiler/crystal/syntax/to_s.cr b/src/compiler/crystal/syntax/to_s.cr
@@ -1064,8 +1064,7 @@ module Crystal
       case node
       when Expressions
         @str << "("
-        node.expressions.each_with_index do |exp, j|
-          @str << ", " if j > 0
+        node.expressions.join(@str, ", ") do |exp|
           visit_unpack exp
         end
         @str << ")"