Report number of pending specs (as “disabled”) in Spec::JUnitFormatter

crystal-lang · Dec 19, 2019 · 67ea6ad · 67ea6ad
1 parent c4bc389
commit 67ea6ad
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/spec/std/spec/junit_formatter_spec.cr b/spec/std/spec/junit_formatter_spec.cr
@@ -10,7 +10,7 @@ describe "JUnit Formatter" do
 
     expected = <<-XML
                  <?xml version="1.0"?>
-                 <testsuite tests="2" errors="0" failures="0" time="0.0">
+                 <testsuite tests="2" disabled="0" errors="0" failures="0" time="0.0">
                    <testcase file="spec/some_spec.cr" classname="spec.some_spec" name="should do something"/>
                    <testcase file="spec/some_spec.cr" classname="spec.some_spec" name="should do something else"/>
                  </testsuite>
@@ -26,7 +26,7 @@ describe "JUnit Formatter" do
 
     expected = <<-XML
                  <?xml version="1.0"?>
-                 <testsuite tests="1" errors="0" failures="1" time="0.0">
+                 <testsuite tests="1" disabled="0" errors="0" failures="1" time="0.0">
                    <testcase file="spec/some_spec.cr" classname="spec.some_spec" name="should do something">
                      <failure/>
                    </testcase>
@@ -43,7 +43,7 @@ describe "JUnit Formatter" do
 
     expected = <<-XML
                  <?xml version="1.0"?>
-                 <testsuite tests="1" errors="1" failures="0" time="0.0">
+                 <testsuite tests="1" disabled="0" errors="1" failures="0" time="0.0">
                    <testcase file="spec/some_spec.cr" classname="spec.some_spec" name="should do something">
                      <error/>
                    </testcase>
@@ -63,7 +63,7 @@ describe "JUnit Formatter" do
 
     expected = <<-XML
                  <?xml version="1.0"?>
-                 <testsuite tests="4" errors="2" failures="1" time="0.0">
+                 <testsuite tests="4" disabled="0" errors="2" failures="1" time="0.0">
                    <testcase file="spec/some_spec.cr" classname="spec.some_spec" name="should do something1" time="2.0"/>
                    <testcase file="spec/some_spec.cr" classname="spec.some_spec" name="should do something2" time="0.5">
                      <failure/>

diff --git a/src/spec/junit_formatter.cr b/src/spec/junit_formatter.cr
@@ -16,6 +16,7 @@ module Spec
       io = @io
       io.puts %(<?xml version="1.0"?>)
       io << %(<testsuite tests=") << @results.size
+      io << %(" disabled=") << (@summary[:pending]? || 0)
       io << %(" errors=") << (@summary[:error]? || 0)
       io << %(" failures=") << (@summary[:fail]? || 0)
       io << %(" time=") << elapsed_time.to_f