Compiler: let protected initialize define a protected new

spec/compiler/semantic/visibility_modifiers_spec.cr

@@ -400,4 +400,16 @@ describe "Visibility modifiers" do
       ),
       "undefined local variable or method 'foo'"
   end
+
+  it "defines protected initialize (#7501)" do
+    assert_error %(
+      class Foo
+        protected def initialize
+        end
+      end
+
+      Foo.new
+      ),
+      "protected method 'new' called for Foo.class"
+  end
 end

src/compiler/crystal/semantic/new.cr

@@ -13,6 +13,13 @@ module Crystal
       file_modules.each_value do |file_module|
         define_default_new(file_module)
       end
+
+      # Once we are done with the expansions we mark `initialze` methods
+      # without an explicit visibility as `protected`.
+      new_expansions.each do |expansion|
+        original = expansion[:original]
+        original.visibility = Visibility::Protected if original.visibility.public?
+      end
     end
 
     def define_default_new(type)
@@ -130,7 +137,7 @@ module Crystal
       new_def.splat_index = splat_index
       new_def.double_splat = double_splat.clone
       new_def.yields = yields
-      new_def.visibility = Visibility::Private if visibility.private?
+      new_def.visibility = visibility
       new_def.new = true
       new_def.doc = doc
       new_def.free_vars = free_vars

src/compiler/crystal/types.cr

@@ -822,10 +822,6 @@ module Crystal
     def add_def(a_def)
       a_def.owner = self
 
-      if a_def.visibility.public? && a_def.name == "initialize"
-        a_def.visibility = Visibility::Protected
-      end
-
       item = DefWithMetadata.new(a_def)
 
       defs = (@defs ||= {} of String => Array(DefWithMetadata))