Keep Channel#close thread-safety

crystal-lang · Sep 29, 2019 · 9758210 · 9758210
1 parent cdafa0e
commit 9758210
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/src/channel.cr b/src/channel.cr
@@ -92,17 +92,19 @@ class Channel(T)
   end
 
   def close
-    @closed = true
+    @lock.sync do
+      @closed = true
 
-    @senders.each &.fiber.enqueue
+      @senders.each &.fiber.enqueue
 
-    @receivers.each do |receiver|
-      receiver.state_ptr.value = DeliveryState::Closed
-      receiver.fiber.enqueue
-    end
+      @receivers.each do |receiver|
+        receiver.state_ptr.value = DeliveryState::Closed
+        receiver.fiber.enqueue
+      end
 
-    @senders.clear
-    @receivers.clear
+      @senders.clear
+      @receivers.clear
+    end
     nil
   end