Revert "Add ReferenceStorage for manual allocation of references (#…

…14106)" (#14207)

spec/primitives/reference_spec.cr

@@ -43,7 +43,9 @@ describe "Primitives: reference" do
     end
 
     it "works when address is on the stack" do
-      foo_buffer = uninitialized ReferenceStorage(Foo)
+      # suitably aligned, sufficient storage for type ID + i64 + ptr
+      # TODO: use `ReferenceStorage` instead
+      foo_buffer = uninitialized UInt64[3]
       foo = Foo.pre_initialize(pointerof(foo_buffer))
       pointerof(foo_buffer).as(typeof(Foo.crystal_instance_type_id)*).value.should eq(Foo.crystal_instance_type_id)
       foo.str.should eq("abc")

src/compiler/crystal/codegen/llvm_typer.cr

@@ -245,10 +245,6 @@ module Crystal
       llvm_type(type.remove_alias, wants_size)
     end
 
-    private def create_llvm_type(type : ReferenceStorageType, wants_size)
-      llvm_struct_type(type.reference_type, wants_size)
-    end
-
     private def create_llvm_type(type : NonGenericModuleType | GenericClassType, wants_size)
       # This can only be reached if the module or generic class don't have implementors
       @llvm_context.int1

src/compiler/crystal/program.cr

@@ -197,10 +197,6 @@ module Crystal
       types["Struct"] = struct_t = @struct_t = NonGenericClassType.new self, self, "Struct", value
       abstract_value_type(struct_t)
 
-      types["ReferenceStorage"] = @reference_storage = reference_storage = GenericReferenceStorageType.new self, self, "ReferenceStorage", value, ["T"]
-      reference_storage.declare_instance_var("@type_id", int32)
-      reference_storage.can_be_stored = false
-
       types["Enumerable"] = @enumerable = GenericModuleType.new self, self, "Enumerable", ["T"]
       types["Indexable"] = @indexable = GenericModuleType.new self, self, "Indexable", ["T"]
 
@@ -497,7 +493,7 @@ module Crystal
 
     {% for name in %w(object no_return value number reference void nil bool char int int8 int16 int32 int64 int128
                      uint8 uint16 uint32 uint64 uint128 float float32 float64 string symbol pointer enumerable indexable
-                     array static_array reference_storage exception tuple named_tuple proc union enum range regex crystal
+                     array static_array exception tuple named_tuple proc union enum range regex crystal
                      packed_annotation thread_local_annotation no_inline_annotation
                      always_inline_annotation naked_annotation returns_twice_annotation
                      raises_annotation primitive_annotation call_convention_annotation

src/compiler/crystal/types.cr

@@ -550,7 +550,7 @@ module Crystal
     def allows_instance_vars?
       case self
       when program.object, program.value, program.struct,
-           program.reference, program.class_type, program.reference_storage,
+           program.reference, program.class_type,
            program.number, program.int, program.float,
            program.tuple, program.named_tuple,
            program.pointer, program.static_array,
@@ -2642,32 +2642,6 @@ module Crystal
     end
   end
 
-  # The non-instantiated ReferenceStorage(T) type.
-  class GenericReferenceStorageType < GenericClassType
-    @struct = true
-
-    def new_generic_instance(program, generic_type, type_vars)
-      t = type_vars["T"].type
-
-      unless t.is_a?(TypeParameter) || (t.class? && !t.struct?)
-        raise TypeException.new "Can't instantiate ReferenceStorage(T) with T = #{t} (T must be a reference type)"
-      end
-
-      ReferenceStorageType.new program, t
-    end
-  end
-
-  class ReferenceStorageType < GenericClassInstanceType
-    getter reference_type : Type
-
-    def initialize(program, @reference_type)
-      t_var = Var.new("T", @reference_type)
-      t_var.bind_to t_var
-
-      super(program, program.reference_storage, program.struct, {"T" => t_var} of String => ASTNode)
-    end
-  end
-
   # A lib type, like `lib LibC`.
   class LibType < ModuleType
     getter link_annotations : Array(LinkAnnotation)?

src/prelude.cr

@@ -65,7 +65,6 @@ require "raise"
 require "random"
 require "range"
 require "reference"
-require "reference_storage"
 require "regex"
 require "set"
 {% unless flag?(:wasm32) %}