Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid memory access in test_alpine #10366

Closed
straight-shoota opened this issue Feb 5, 2021 · 3 comments · Fixed by crystal-lang/distribution-scripts#195
Closed

Invalid memory access in test_alpine #10366

straight-shoota opened this issue Feb 5, 2021 · 3 comments · Fixed by crystal-lang/distribution-scripts#195

Comments

@straight-shoota
Copy link
Member

The test_alpine job is broken on master. Example of a broken build: https://github.com/crystal-lang/crystal/runs/1818349096
The earliest broken nightly build is 33c97d4. So it would seem that the relevant change was introduced between that and dc0a32f. However, PR builds before that already show the same error, for example in 77f7f02
But the following nightly was okay, so the error doesn't reproduce consistently. In CI it appears always very early on in compiler specs after the first couple of examples. But locally I've seen it occur later on after a few dozend examples.

@bcardiff
Copy link
Member

bcardiff commented Feb 5, 2021

You mean locally as in local docker or local alpine?

I think it's started to fail more often with the update to alpine:3.13. But it doesn't make much sense either.

We could try to run alpine test with verbose for a while to see if it's always in the same spec.

@straight-shoota
Copy link
Member Author

I ran compiler_spec locally in the alpine build container. And it reproduced similar, but not exactly the same spec.

As far as I can see, in CI it always breaks in the third spec or not at all. So verbose output wouldn't be necessary to track that.

@bcardiff
Copy link
Member

The alpine images based on 3.13 have some issues. The maintenance_release is unable to succeed and also the test_alpine.

I've verified that locally, it fails in the make crystal compiler_spec as in the CI.

So for now I am reverting the alpine images to 3.12 as published at crystal-lang/distribution-scripts@80c83b2 . But I am leaving the 3.13 alpine images just in case

The related docker images are:

* crystallang/crystal:0.36.1-alpine = crystallang/crystal:0.36.1-3.12-alpine
* crystallang/crystal:0.36.1-alpine-build = crystallang/crystal:0.36.1-3.12-alpine-build
* crystallang/crystal:0.36.1-3.13-alpine-build
* crystallang/crystal:0.36.1-3.13-alpine

Ref from crystal-lang/distribution-scripts#83:

[..] After crystal-lang/distribution-scripts#79 the crystal binaries end up with some shared libraries linked and the maintenance_release complains https://app.circleci.com/pipelines/github/crystal-lang/crystal/5427/workflows/8f62a04e-4e79-4633-8952-77e7c777dc00 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants