Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make std_spec bug #14200

Closed
femto opened this issue Jan 10, 2024 · 8 comments · Fixed by #14219
Closed

make std_spec bug #14200

femto opened this issue Jan 10, 2024 · 8 comments · Fixed by #14219
Labels
kind:bug kind:regression Something that used to correctly work but no longer works topic:stdlib:networking
Milestone

Comments

@femto
Copy link
Contributor

femto commented Jan 10, 2024

Bug Report

now it comes to

...................*.........Unhandled exception in spawn: SSL_read: I/O error (OpenSSL::SSL::Error)
  from src/openssl/ssl/socket.cr:137:9 in 'unbuffered_read'
  from src/io/buffered.cr:263:5 in 'fill_buffer'
  from src/io/buffered.cr:105:7 in 'peek'
  from src/http/request.cr:180:15 in 'parse_request_line'
  from src/http/request.cr:153:12 in 'from_io:max_request_line_size:max_headers_size'
  from src/http/server/request_processor.cr:30:19 in 'process'
  from src/http/server.cr:521:5 in 'handle_client'
  from src/http/server.cr:451:5 in '->'
  from src/fiber.cr:146:11 in 'run'
  from src/fiber.cr:98:34 in '->'
Caused by: SSL_read: No such file or directory (RuntimeError)

@Blacksmoke16
Copy link
Member

Did you try on the latest commit in master? Would have thought this would have been fixed by #14169 given it's the same error message.

@femto
Copy link
Contributor Author

femto commented Jan 10, 2024

my commit is
0b57b6c (HEAD -> master, github/master) Add Signal::trap_handler? (#14126)

@femto
Copy link
Contributor Author

femto commented Jan 10, 2024

Unhandled exception in spawn: SSL_read: I/O error (OpenSSL::SSL::Error)
  from src/openssl/ssl/socket.cr:137:9 in 'unbuffered_read'
  from src/io/buffered.cr:263:5 in 'fill_buffer'
  from src/io/buffered.cr:105:7 in 'peek'
  from src/http/request.cr:180:15 in 'parse_request_line'
  from src/http/request.cr:153:12 in 'from_io:max_request_line_size:max_headers_size'
  from src/http/server/request_processor.cr:30:19 in 'process'
  from src/http/server.cr:521:5 in 'handle_client'
  from src/http/server.cr:451:5 in '->'
  from src/fiber.cr:146:11 in 'run'
  from src/fiber.cr:98:34 in '->'
Caused by: SSL_read: No such file or directory (RuntimeError)
..................................................................................................................................................................................................................................................................................................................................................................................................................*................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Pending:
  String #reverse converts invalid code units to replacement char
  Regex #matches_at_byte_index? negative
  Regex #match with pos negative
  Regex #match_at_byte_index negative
  Spec matchers pending block is not compiled pending has block with valid syntax, but invalid semantics
  String#each_grapheme GB9c
  String#each_grapheme GB9c
  String#each_grapheme GB9c
  String#each_grapheme GB9c
  String#each_grapheme GB9c
  String#each_grapheme GB9c
  String#each_grapheme GB9c
  URI .parse unescaped @ in user/password should not confuse host
  Number #round edge cases
  UDPSocket using IPv6 joins and transmits to multicast groups
  UDPSocket sends broadcast message
  UDPSocket #connect with a IPv6 address
  concurrent schedules intermitting sleeps
  Math Functions for computing quotient and remainder
  OpenSSL::X509::Certificate #digest
  OpenSSL::SSL::Context ciphers uses intermediate default ciphers
  Path #expand converts a pathname to an absolute pathname, using a complete path assert

Finished in 2:25 minutes
17646 examples, 0 failures, 0 errors, 22 pending

the error output in the middle,
but it says 0 failures

@femto
Copy link
Contributor Author

femto commented Jan 10, 2024

now it becomes

Unhandled exception in spawn: SSL_read: I/O error (OpenSSL::SSL::Error)
  from src/openssl/ssl/socket.cr:137:9 in 'unbuffered_read'
  from src/io/buffered.cr:263:5 in 'fill_buffer'
  from src/io/buffered.cr:105:7 in 'peek'
  from src/http/request.cr:180:15 in 'parse_request_line'
  from src/http/request.cr:153:12 in 'from_io:max_request_line_size:max_headers_size'
  from src/http/server/request_processor.cr:30:19 in 'process'
  from src/http/server.cr:521:5 in 'handle_client'
  from src/http/server.cr:451:5 in '->'
  from src/fiber.cr:146:11 in 'run'
  from src/fiber.cr:98:34 in '->'
Caused by: SSL_read: No child processes (RuntimeError)

@straight-shoota
Copy link
Member

Looks like #14169 didn't really resolve this then. I wasn't too sure it would actually work 🤷

@straight-shoota
Copy link
Member

A similar error has shown up in CI: https://app.circleci.com/pipelines/github/crystal-lang/crystal/13996/workflows/386aaf3d-e451-4ea9-9239-84d944072f6b/jobs/81050

This runs in the crystallang/crystal:1.11.0-build image with OpenSSL 3.0.2.

@straight-shoota straight-shoota added this to the 1.11.1 milestone Jan 11, 2024
@straight-shoota straight-shoota added the kind:regression Something that used to correctly work but no longer works label Jan 11, 2024
@straight-shoota
Copy link
Member

straight-shoota commented Jan 11, 2024

I'm declaring this as a (potential) regression because it appears as if #14169 might've degraded stability on previously sound workloads.

Apparently it couldn't really solve the problem with 3.2 and instead it even brought issues to older versions. So we should probably revert it.

@straight-shoota
Copy link
Member

Resolved by #14217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug kind:regression Something that used to correctly work but no longer works topic:stdlib:networking
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants