Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Signal#trap_handler? #14126

Merged
merged 10 commits into from Jan 9, 2024
Merged

Add Signal#trap_handler? #14126

merged 10 commits into from Jan 9, 2024

Conversation

stakach
Copy link
Contributor

@stakach stakach commented Dec 20, 2023

resolves #13803

straight-shoota
straight-shoota approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@straight-shoota straight-shoota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stakach stakach requested a review from Fryguy December 20, 2023 22:09
Sija
Sija reviewed Dec 23, 2023
View reviewed changes
src/signal.cr Outdated Show resolved Hide resolved
stakach and others added 2 commits December 28, 2023 08:12
@stakach @HertzDevil
Update src/crystal/system/wasi/signal.cr
abff6c1 
Co-authored-by: Quinton Miller <nicetas.c@gmail.com>
@stakach @HertzDevil
Update src/crystal/system/win32/signal.cr
6ef5edf 
Co-authored-by: Quinton Miller <nicetas.c@gmail.com>
@straight-shoota straight-shoota added this to the 1.12.0 milestone Jan 4, 2024
@straight-shoota straight-shoota changed the title feat: chainable signals Add Signal::trap_handler? Jan 9, 2024
@straight-shoota straight-shoota merged commit 0b57b6c into crystal-lang:master Jan 9, 2024
56 checks passed
@stakach stakach deleted the chainable-signals branch January 10, 2024 04:36
@femto femto mentioned this pull request Jan 10, 2024
Closed
@stakach stakach mentioned this pull request Jan 23, 2024
Closed
@straight-shoota straight-shoota changed the title Add Signal::trap_handler? Add Signal#trap_handler? Apr 8, 2024
@BrewTestBot BrewTestBot mentioned this pull request Apr 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@straight-shoota straight-shoota straight-shoota approved these changes

@HertzDevil HertzDevil HertzDevil approved these changes

@Fryguy Fryguy Awaiting requested review from Fryguy

Assignees
No one assigned
Labels
kind:feature platform:unix topic:stdlib:system
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Signal#trap should return previous handler
6 participants
@stakach @Sija @Fryguy @straight-shoota @HertzDevil @Blacksmoke16