Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalizing Exception messages #3944

Closed
Sija opened this issue Jan 27, 2017 · 2 comments
Closed

Capitalizing Exception messages #3944

Sija opened this issue Jan 27, 2017 · 2 comments

Comments

@Sija
Copy link
Contributor

Sija commented Jan 27, 2017

When using Crystal I've noticed that Exception messages have mixed casing throughout the code. In certain places they're being written lowercased (see EOFError#initialize), while at others being capitalized (see Hash#fetch).

If there's a will to standarize it I can send a PR changing all of them to one specified form - for example capitalizing all of them (which seems to me as more elegant since error messages, longer ones at least, tend use sentence-casing anyway).

@matiasgarciaisaia
Copy link
Member

I think this should be a convention to follow rather than some code we should write. Writing logic for handling this cases doesn't seem wise. Maybe linting, but not more than that.

That PR to fix the current codebase would be great, though :)

@Sija
Copy link
Contributor Author

Sija commented Feb 19, 2017

Closed by #3956

@Sija Sija closed this as completed Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants