Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatter places double newline after getter with comment #4672

Closed
RX14 opened this issue Jul 4, 2017 · 2 comments
Closed

Formatter places double newline after getter with comment #4672

RX14 opened this issue Jul 4, 2017 · 2 comments
Labels
kind:bug kind:feature

Comments

@RX14
Copy link
Contributor

RX14 commented Jul 4, 2017 •
edited 

class Foo
  getter value : String # comment

  def method
  end
end

gets formatted to

class Foo
  getter value : String # comment


  def method
  end
end

Crystal 0.23.0 (and 0.22.0).
@sdogruyol
Copy link
Member

sdogruyol commented Jul 4, 2017 •
edited

We should ping formatter master @makenowjust 👍

makenowjust added a commit to makenowjust/crystal that referenced this issue Jul 9, 2017
@makenowjust
Format: fix to place only a newline between call-comment-newline and def
abb9672 
Fixed crystal-lang#4672
@makenowjust makenowjust mentioned this issue Jul 9, 2017
Merged
@makenowjust
Copy link
Contributor

This is heavy.

asterite pushed a commit that referenced this issue Sep 8, 2017
@makenowjust @asterite
Format: fix to place only a newline between call-comment-newline and def
cd4c132 
Fixed #4672
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:bug kind:feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mverzilli @sdogruyol @RX14 @makenowjust