Error: undefined constant ENV

[n-rodriguez]

Hi there!

I got this bug on GithubActions :

Run make spec
crystal spec
Showing last frame. Use --error-trace for full trace.

In /usr/share/crystal/src/time/location.cr:335:15

 335 | case tz = ENV["TZ"]?
                 ^
Error: undefined constant ENV
make: *** [spec] Error 1
Makefile:18: recipe for target 'spec' failed
##[error]Process completed with exit code 2.

I don't have this error on my machine :

nicolas@laptop:~/PROJECTS/CRYSTAL/stacker$ make spec
crystal spec
..................

Finished in 7.0 milliseconds
18 examples, 0 failures, 0 errors, 0 pending

ArchLinux

Crystal 0.35.1 [5999ae29b] (2020-06-19)

LLVM: 8.0.0
Default target: x86_64-unknown-linux-gnu

And the tests passed 1h before : https://github.com/jbox-web/stacker/runs/1009908500?check_suite_focus=true

[n-rodriguez]

The culprit seems to be https://github.com/crystal-lang/crystal-env

I try a build without it and it pass : https://github.com/jbox-web/stacker/runs/1010236344?check_suite_focus=true

[n-rodriguez]

I've created a branch that shows the bug :

https://github.com/jbox-web/stacker/tree/wip/env
https://github.com/jbox-web/stacker/runs/1010260636?check_suite_focus=true

[bcardiff]

Oh! The shard crystal-env, when included as env (as it is expected) ends up hidding the std-lib env module 🤦 .

The shard should be renamed to avoid this issue 😞