Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Regex::MatchData#[] overloading to range #10076

Merged
merged 1 commit into from Dec 14, 2020
Merged

Add Regex::MatchData#[] overloading to range #10076

merged 1 commit into from Dec 14, 2020

Conversation

makenowjust
Copy link
Contributor

It seems natural that MatchData#[] supports a range.
In short, I think the following code can run:

m = /(a)(b)/.match("ab")
p m.not_nil![1..2]

In fact, Ruby supports this.

This PR adds MatchData#[] overloading to Range (and Int, Int).

asterite
asterite approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@asterite asterite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@asterite asterite added this to the 1.0.0 milestone Dec 14, 2020
@asterite asterite merged commit 4c5b326 into crystal-lang:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:text
Projects
None yet
Milestone
0.36.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@makenowjust @asterite @straight-shoota