Newlines in OptionParser option descriptions should be indented #10183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -278,8 +278,10 @@ class OptionParser | |||
| end | |||
|
|
|||
| private def append_flag(flag, description) | |||
| indent = " " * 37 | |||
There was a problem hiding this comment.
I'm pretty sure that fixed number won't work well with flags that are less than 33 characters long.
There was a problem hiding this comment.
This indent is only used for the description or in case flags are longer than 33 characters.
In the test spec both cases are tested (flags.size < 33 and flags.size > 33).
There was a problem hiding this comment.
Sorry, I was mistaken about how the indent works for flag.size < 33.
There was a problem hiding this comment.
Isn't it used in the following line (before the if flag.size >= 33)?
straight-shoota
approved these changes
Jan 3, 2021
|
I changed the description from "relates" to "fixes" so the linked issue is automatically closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5832