DWARF: Disable GC around dl_iterate_phdr in freebsd #10259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about #10084 (comment)? |
|
I think that would require iterating the structure twice, to count the required memory. Disabling the GC seems a less error prone approach to me. |
straight-shoota
approved these changes
Jan 18, 2021
|
@straight-shoota mmm, no. There is no llvm issue here. We are preventing a deadlock in freebsd. |
|
Okay, if that's all. Sry, I couldn't look into it more closely, just rememberd your initial hunch it might be caused by LLVM. |
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Feb 12, 2021
ChangeLog: https://github.com/crystal-lang/crystal/blob/0.36.1/CHANGELOG.md Should fix this issue: crystal-lang/crystal#10259 PR: 253111 Submitted by: rlwestlund@gmail.com Approved by: greg@unrelenting.technology (maintainer) MFH: 2021Q1 (runtime fix) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@565009 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Feb 12, 2021
ChangeLog: https://github.com/crystal-lang/crystal/blob/0.36.1/CHANGELOG.md Should fix this issue: crystal-lang/crystal#10259 PR: 253111 Submitted by: rlwestlund@gmail.com Approved by: greg@unrelenting.technology (maintainer) MFH: 2021Q1 (runtime fix)
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Feb 12, 2021
lang/crystal: Update to 0.36.1 ChangeLog: https://github.com/crystal-lang/crystal/blob/0.36.1/CHANGELOG.md Should fix this issue: crystal-lang/crystal#10259 PR: 253111 Submitted by: rlwestlund@gmail.com Approved by: greg@unrelenting.technology (maintainer)
Jehops
pushed a commit
to Jehops/freebsd-ports-legacy
that referenced
this pull request
Feb 12, 2021
ChangeLog: https://github.com/crystal-lang/crystal/blob/0.36.1/CHANGELOG.md Should fix this issue: crystal-lang/crystal#10259 PR: 253111 Submitted by: rlwestlund@gmail.com Approved by: greg@unrelenting.technology (maintainer) MFH: 2021Q1 (runtime fix) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@565009 35697150-7ecd-e111-bb59-0022644237b5
dch
pushed a commit
to skunkwerks/ports
that referenced
this pull request
Feb 14, 2021
ChangeLog: https://github.com/crystal-lang/crystal/blob/0.36.1/CHANGELOG.md Should fix this issue: crystal-lang/crystal#10259 PR: 253111 Submitted by: rlwestlund@gmail.com Approved by: greg@unrelenting.technology (maintainer) MFH: 2021Q1 (runtime fix)
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Apr 1, 2021
lang/crystal: Update to 0.36.1 ChangeLog: https://github.com/crystal-lang/crystal/blob/0.36.1/CHANGELOG.md Should fix this issue: crystal-lang/crystal#10259 PR: 253111 Submitted by: rlwestlund@gmail.com Approved by: greg@unrelenting.technology (maintainer)
svmhdvn
pushed a commit
to svmhdvn/freebsd-ports
that referenced
this pull request
Jan 10, 2024
ChangeLog: https://github.com/crystal-lang/crystal/blob/0.36.1/CHANGELOG.md Should fix this issue: crystal-lang/crystal#10259 PR: 253111 Submitted by: rlwestlund@gmail.com Approved by: greg@unrelenting.technology (maintainer) MFH: 2021Q1 (runtime fix)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10084. Prevents deadlock as shown in #10084 (comment)
I don't know if it's a good idea to disable it in every platform or in every bsd platform.