Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser: allow more macros names back #10338

Merged
merged 2 commits into from
Jan 30, 2021
Merged

Parser: allow more macros names back #10338

merged 2 commits into from
Jan 30, 2021

Conversation

asterite
Copy link
Member

Partially reverts #10069
Superseds #10314

This retains the "macros can't have a receiver" from #10069 but allows all kinds of names and operators for macros, including setters (this is new). Because this is perfectly fine:

class Foo
  macro bar=(x)
    puts "Setting #{ {{x}} }"
  end
end

Foo.bar = 1

@asterite asterite added kind:bug topic:compiler:parser kind:regression Something that used to correctly work but no longer works labels Jan 30, 2021
@asterite asterite added this to the 0.36.1 milestone Jan 30, 2021
@asterite asterite merged commit 33c97d4 into master Jan 30, 2021
@asterite asterite deleted the regression/macro-names branch January 30, 2021 13:37
bcardiff pushed a commit that referenced this pull request Jan 30, 2021
* Parser: allow more macros names back

* Formatter: format setter macros
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug kind:regression Something that used to correctly work but no longer works topic:compiler:parser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants