Parser: refactor 'foo.%` call parsing #10351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed crystal-lang#10296 Currently, `%` call parsing is specialized like `if current_char == '%'` way in the parser, to avoid a confliction with `%`-string literals. However, the lexer has `wants_def_or_macro_name` flag for such things, we should use this instead of custom `if` way. The commit fixes the formatter also to set `wants_def_or_macro_name` flag correctly.
straight-shoota
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #10296
Currently,
%call parsing is specialized likeif current_char == '%'way in the parser, to avoid a confliction with%-string literals. However, the lexer haswants_def_or_macro_nameflag for such things, we should use this instead of the customifway.The commit fixes the formatter also to set
wants_def_or_macro_nameflag correctly.