Compiler: access instantiations of NamedTuple and other generics uniformly #10401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10380.
#10380 (comment) now works. The following will now correctly fail to compile (with the default prelude):
This replaces
Crystal::GenericType#generic_types
with#instantiated_types
, so thatCrystal::NamedTupleType
can redefine it. Note that the keys ofCrystal::GenericType#@generic_types
andCrystal::NamedTupleType#@instantiations
are never accessed outside those compiler types' instantiation methods repsectively (they are only used for caching instantiations with the same type arguments).