Remove implicit path=/ from HTTP::Cookie
#10491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
approved these changes
Mar 15, 2021
3 tasks
|
@bcardiff seems that doc is outdate in https://crystal-lang.org/api/1.0.0/HTTP/Cookies.html#[]=(key,value:String)-instance-method |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pathproperty of an HTTP cookie has no fixed default value and omitting the attribute entirely has significantly different semantics from/(see RFC 6265 §4.1.2.4). Currently, omission is impossible because theHTTP::Cokie#pathproperty is non-nilable (it was nilable prior to #1498 and the serialization code still checks fornil). Thus the parser incorrectly setspath= "/"if the value is omitted, which changes semantics.This patch makes the
pathproperty nilable and removes the default value/.We could consider keeping
/as default in the constructor, if we want the match-all semantics by default. But I think sticking with the standard semantics for omitting the value is better.