examples: fix (2021-03) #10505
Merged
examples: fix (2021-03) #10505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
requested changes
Mar 12, 2021
src/json/to_json.cr
Outdated
| @@ -227,20 +227,9 @@ module Enum::ValueConverter(T) | |||
| # used for serialization. | |||
| # | |||
| # ``` | |||
| # enum Stages | |||
There was a problem hiding this comment.
I think these are needed to have a self-contained example.
There was a problem hiding this comment.
I had removed it because the test failed with the definition of the enum of the same name.
However, the clarity of the example should be a priority, so I reverted and will modify my tool. 馃憤
src/json/to_json.cr
Outdated
| # Enum::ValueConverter.to_json(Stages::INITIAL) # => %(0) | ||
| # Enum::ValueConverter.to_json(Stages::SECOND_STAGE) # => %(1) | ||
| # | ||
| # @[Flags] |
Sija
reviewed
Mar 12, 2021
Co-authored-by: Brian J. Cardiff <bcardiff@gmail.com>
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
bcardiff
reviewed
Mar 13, 2021
src/yaml/to_yaml.cr
Outdated
| @@ -193,24 +193,13 @@ module Enum::ValueConverter(T) | |||
| # used for serialization. | |||
| # | |||
| # ``` | |||
| # enum Stages | |||
There was a problem hiding this comment.
Sorry, i just noticed that here there are also some definitions that should stay in order to make them self-contained.
There was a problem hiding this comment.
Oh, I missed to revert the yaml one. 馃槂
bcardiff
approved these changes
Mar 13, 2021
straight-shoota
approved these changes
Mar 13, 2021
sdogruyol
approved these changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch up examples before crystal-1.0.0 馃槂
Best regards,