Add IO::Sized#remaining=(value) to reuse an existing instance #10520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
approved these changes
Mar 19, 2021
jgaskins
added a commit
to jgaskins/crystal-pg
that referenced
this pull request
Mar 19, 2021
This PR should be released with Crystal 1.0, but this will allow us to use this feature until then. See: crystal-lang/crystal#10520
straight-shoota
approved these changes
Mar 19, 2021
|
I think we can include this small feature in 1.0, right? |
jgaskins
added a commit
to jgaskins/crystal-pg
that referenced
this pull request
Mar 19, 2021
This was added in crystal-lang/crystal#10520 but will not be released until Crystal 1.0. Once this shard drops support for Crystal < 1.0, this commit can be reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IO::Sizedis an excellent abstraction for segmenting anIOand gives you the tools to ensure that that segment is completely consumed when you leave a block regardless of whether it was consumed inside the block itself. But if you need to segment thatIOinto a lot of small-ish chunks you end up re-allocating hundreds, thousands, or even millions ofIO::Sizedinstances, which can involve a lot ofmalloc, GC, andfreecalls.You can see the impact in this PR to
will/crystal-pgwhere we reduced CPU usage by 73% for a Postgres query that returns 500k values (5 columns x 100k rows). In that PR @straight-shoota recommended adding that functionality directly toIO::Sized.