Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #positive? & #negative? to Number and Time::Span #10601

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Add #positive? & #negative? to Number and Time::Span #10601

merged 1 commit into from
Apr 12, 2021

Conversation

Blacksmoke16
Copy link
Member

Resolves #8917.

@Blacksmoke16 Blacksmoke16 changed the title Add #positive? & #negative to Number and Time::Span Add #positive? & #negative? to Number and Time::Span Apr 4, 2021
sdogruyol
sdogruyol approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@sdogruyol sdogruyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Blacksmoke16 🙏

@straight-shoota straight-shoota added this to the 1.1.0 milestone Apr 10, 2021
@straight-shoota straight-shoota merged commit 5b2a744 into crystal-lang:master Apr 12, 2021
@Blacksmoke16 Blacksmoke16 deleted the positive-negative branch April 12, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@sdogruyol sdogruyol sdogruyol approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib:numeric
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Add Number#positive? and #negative?
3 participants
@Blacksmoke16 @straight-shoota @sdogruyol