-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor index / count normalization in range-like methods #10753
Merged
straight-shoota
merged 6 commits into
crystal-lang:master
from
HertzDevil:refactor/indexable-start-and-count
Jun 17, 2021
Merged
Refactor index / count normalization in range-like methods #10753
straight-shoota
merged 6 commits into
crystal-lang:master
from
HertzDevil:refactor/indexable-start-and-count
Jun 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
May 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great simplification, thanks!
oprypin
reviewed
May 31, 2021
oprypin
reviewed
Jun 4, 2021
oprypin
approved these changes
Jun 5, 2021
asterite
approved these changes
Jun 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! It seems there are merge conflicts.
@HertzDevil this needs an update again |
…e-start-and-count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor captures the index / count normalization in many
Indexable
methods and some others outside; it is the range-like equivalent ofIndexable#check_index_out_of_bounds
.Related to #10243. (Any method that uses
normalize_start_and_count
orrange_to_index_and_count
will have the same index behaviour noted there.)There are at least two methods where this refactor does not apply, because they require exactly
count
elements and not "count
or less" elements:Array(T)#fill(value : T, from : Int, count : Int)
Slice(T)#[]?(start : Int, count : Int)