Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move win32 libc bindings from winbase.cr to approriate files #10771

Merged

Conversation

straight-shoota
Copy link
Member

winbase.cr served as a kind of holding center for all kinds of methods, that are actually defined in other headers files. This patch moves them all to the appropriate places. Everything that's left is as far as I can see, actually defined in winbase.h.

@straight-shoota straight-shoota force-pushed the refactor/win32-bindings branch 2 times, most recently from 2da2176 to 34b069a Compare May 31, 2021 14:36
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Johannes!

@straight-shoota straight-shoota added this to the 1.1.0 milestone Jun 2, 2021
@straight-shoota straight-shoota merged commit 93a65e3 into crystal-lang:master Jun 4, 2021
@straight-shoota straight-shoota deleted the refactor/win32-bindings branch June 4, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants