Make #is_a?
in macros respect the AST node hierarchy
#11062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
is_a?
in macros compares the class names directly:Since
Crystal::ASTNode
is an abstract class, it follows thatis_a?(ASTNode)
always fails, even though every AST node obviously inherits from that class, both in the macro language and internally. This PR makes the internal AST node hierarchy available here, sois_a?(ASTNode)
becomes true.More useful is the ability to match abstract AST node types that aren't
ASTNode
: